Use improved obj ptr api - #538
Merged
Merged
Conversation
NikolayChirkov
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored ObjPtr to use a type-erased cache owned by ObjectPtrBase, enabling strongly typed persistent references with incomplete types and PIMPL-friendly headers.
Added ProxyPtr to avoid expensive temporary Ptr copies during normal access, while preserving owning conversions when needed. Centralized serialization, loading, visitor handling, and cache ownership in ObjectPtrBase, migrated typed persistent references, removed obsolete casts, and added coverage for ownership, moves, forward declarations, visitors, and serialization.
This also reduced footprint a little.